Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: rename host parser's isNotSpecial to isOpaque #789

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Editorial: rename host parser's isNotSpecial to isOpaque #789

merged 1 commit into from
Sep 20, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 20, 2023 •
edited by pr-preview bot
Loading

Double negatives are hard to read.

Preview | Diff

@annevk
Copy link
Member Author

annevk commented Sep 20, 2023

@karwa or @rmisev want to double check?

rmisev
rmisev approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@rmisev rmisev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear: if isOpaque is true, then opaque-host parser is invoked. LGTM

@annevk annevk merged commit 9057992 into main Sep 20, 2023
1 check passed
@annevk annevk deleted the annevk/opaque-hosts branch September 20, 2023 16:44
@karwa
Copy link
Contributor

karwa commented Sep 26, 2023

🙌 Thank you! Much clearer now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmisev rmisev rmisev approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @karwa @rmisev